Fix None position values in publishDiagnostics message #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some issues eslint triggers error with no `endLine` and/or `endColumn` defined. In that case the code should use `line` and `column` for the values, respectively. While the code has attempted to do that, it only checked for `null` value for those while eslint actually doesn't even have them set so they are undefined. Fix by checking that value is either null or undefined. This problem causes random exceptions on some LSP clients (for me it triggered in Sublime LSP). Not sure if it affected Vetur. Resolves microsoft#752
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some issues eslint triggers error with no
endLineand/orendColumndefined. In that case the code should uselineandcolumnfor the values, respectively. While the code has attempted todo that, it only checked for
nullvalue for those while eslintactually doesn't even have them set so they are undefined.
Fix by checking that value is either null or undefined.
This problem causes random exceptions on some LSP clients (for me it
triggered in Sublime LSP). Not sure if it affected Vetur.
Resolves #752